RevDiff: Allow path filter for several files #10303
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to #10295
Proposed changes
Allow multi select files in rev diff to filter multiple files. See #10295 for a use case.
It is possible to filter folders in file tree today, but no GUI way to select multiple files.
Multiple files can be added in the advanced filter form though.
The first file is visible in the title
All files are visible in the tool tip
This exposes the possibility to add several files in rev diff file status list.
I believe this covers the important use case, I have thought about some enhancements and rejected them:
Adding would be simple, but not so easy to explain in the menu.
Would require some data structure changes (files stored as string right now), easier to understand in context menus though.
Not enabled now.
Possible, but would require some call changes.
Screenshots
Before
Multiselect disables file filters.
After
Test methodology
Manual
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.